<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Yes, you don't need to NULL terminate the argument list now.<div class="">Here's a link to the commit:</div><div class=""><a href="http://mail-index.netbsd.org/source-changes/2019/04/26/msg105454.html" class="">http://mail-index.netbsd.org/source-changes/2019/04/26/msg105454.html</a></div><div class=""><br class=""></div><div class="">Best,</div><div class=""><br class=""></div><div class="">christos</div><div class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Apr 29, 2019, at 7:39 AM, Pavel Labath <<a href="mailto:pavel@labath.sk" class="">pavel@labath.sk</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">On 26/04/2019 18:56, Christos Zoulas wrote:<br class=""><blockquote type="cite" class="">On Apr 26, 3:11pm, <a href="mailto:reviews@reviews.llvm.org" class="">reviews@reviews.llvm.org</a> (Pavel Labath via Phabricator) wrote:<br class="">-- Subject: [PATCH] D61191: Editline: Fix an msan error<br class="">|<br class="">| --b1_b299efcc557883c5ff30a5eebc16e12b<br class="">| Content-Type: text/plain; charset=us-ascii<br class="">| Content-Transfer-Encoding: quoted-printable<br class="">|<br class="">| labath created this revision.<br class="">| labath added reviewers: christos, krytarowski, davide.<br class="">|<br class="">| Despite the documentation for the el_get(EL_GETTC) function claiming the<br class="">| vararg part is (const char *name, void *value), in reality the function<br class="">| expects the vararg list to be terminated by a null pointer, which can be<br class="">| clearly seen by examining the source code. Although this is mostly<br class="">| bening because the extra values are not used it any way, it still lights<br class="">| up as an error when running the tests under msan.<br class="">|<br class="">| Work around this quirk by adding an explicit nullptr to the end of the<br class="">| argument list.<br class="">|<br class="">|<br class="">| <a href="https://reviews.llvm.org/D61191" class="">https://reviews.llvm.org/D61191</a><br class="">fixed, thanks!<br class="">christos<br class=""></blockquote><br class=""><br class="">Oooh, thanks for the super-fast fix.<br class=""><br class="">Just to confirm, by "fixed" you mean that it should now not be needed to terminate the vararg list with a null pointer?<br class=""><br class="">Do you have anything (a revision, version number or something) that I can leave as a trail to future maintainers to remove this workaround when the fixed libedit becomes more widely available?<br class=""><br class="">pl<br class=""></div></div></blockquote></div><br class=""></div></body></html>