[Lldb-commits] [PATCH] D61073: [lldb] [lit] Add feature flags for native CPU features

[Michał Górny via Phabricator via lldb-commits]

mgorny marked an inline comment as done.
mgorny added inline comments.


================
Comment at: lldb/lit/lit.cfg.py:81
+    cpuid_exe = lit.util.which('lit-cpuid', config.lldb_tools_dir)
+    if cpuid_exe is not None:
+        out, err, exitcode = lit.util.executeCommand([cpuid_exe])
----------------
labath wrote:
> So if the binary is not found for any reason, this will just silently skip the relevant tests, right? Would it make sense to at least print a warning in this case?
Yes, it will skip them. I don't have an opinion on whether it's something we should warn about; but I can surely add one.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61073/new/

https://reviews.llvm.org/D61073