[Lldb-commits] [PATCH] D61073: [lldb] [lit] Add feature flags for native CPU features

[Pavel Labath via Phabricator via lldb-commits]

labath added a reviewer: JDevlieghere.
labath added a subscriber: JDevlieghere.
labath added a comment.

I like this approach, but as this is a novel idea, I'd like to get more opinions first. @JDevlieghere, what do you think?



================
Comment at: lldb/lit/lit.cfg.py:81
+    cpuid_exe = lit.util.which('lit-cpuid', config.lldb_tools_dir)
+    if cpuid_exe is not None:
+        out, err, exitcode = lit.util.executeCommand([cpuid_exe])
----------------
So if the binary is not found for any reason, this will just silently skip the relevant tests, right? Would it make sense to at least print a warning in this case?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61073/new/

https://reviews.llvm.org/D61073