[Lldb-commits] [PATCH] D60984: [Reproducers] Limit logging to calls that cross the API boundary.

[Pavel Labath via Phabricator via lldb-commits]

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

Logging only external calls makes sense to me. The one thing I was not sure about is the name of the `Recorder` class, since it's responsibility was now extended to include logging (and that has affected its design). However, I couldn't come up with a better name, and I suppose logging could be considered a form of recording, so maybe that's fine as it is. It might be good to mention the new role in the class description too...



================
Comment at: lldb/source/Utility/ReproducerInstrumentation.cpp:106
+    : m_serializer(nullptr), m_pretty_func(pretty_func),
+      m_pretty_args(pretty_args), m_local_boundary(false),
       m_result_recorded(true) {
----------------
`std::move(pretty_args)`


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60984/new/

https://reviews.llvm.org/D60984