[Lldb-commits] [PATCH] D60984: [Reproducers] Limit logging to calls that cross the API boundary.

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere created this revision.
JDevlieghere added reviewers: jasonmolenda, jingham, labath.
Herald added a project: LLDB.

We recently moved API logging into the instrumentation macros. This made that logging is now consistent and abstracted behind a macro for every API functions, independent of the reproducers. It also means we have a lot more output. While this is a good thing, it also meant a lot more noise in the log, from things that aren't always equally interesting, such as the copy constructor for example.

To improve usability, we should increase the signal-to-noise ratio. I propose to achieve this by only logging API functions that cross the API boundary. This is a divergence of what we had before, where a select number of functions were logged, irregardless of the API boundary, a concept that was introduced for the reproducers. However, I believe this is in line with the purpose of the API log.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D60984

Files:
  lldb/include/lldb/Utility/ReproducerInstrumentation.h
  lldb/source/Utility/ReproducerInstrumentation.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D60984.196139.patch
Type: text/x-patch
Size: 18463 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190422/18741ee3/attachment-0001.bin>