[Lldb-commits] [PATCH] D60817: [NativePDB] Add anonymous namespaces support

Aleksandr Urakov via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Apr 18 23:56:38 PDT 2019


aleksandr.urakov marked an inline comment as done.
aleksandr.urakov added inline comments.


================
Comment at: lit/SymbolFile/NativePDB/ast-types.cpp:77
+// FIXME: Should be located in the namespace `A`, in the struct `C<1>`.
+A::C<1>::D AC1D;
+
----------------
amccarth wrote:
> Is this a new problem because of your change?  Or is this an already existing problem you discovered in the process?  Is the cause understood?  Should you add a commented-out CHECK showing what the test would be when this problem is fixed?
It's an existing problem, but I didn't go deep into it yet. I've added the test lines describing how it should be, thanks.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60817/new/

https://reviews.llvm.org/D60817





More information about the lldb-commits mailing list