[Lldb-commits] [PATCH] D60817: [NativePDB] Add anonymous namespaces support

[Adrian McCarthy via Phabricator via lldb-commits]

amccarth marked an inline comment as done.
amccarth added inline comments.


================
Comment at: source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp:575
     std::string ns = name_components.front()->toString();
-    context = m_clang.GetUniqueNamespaceDeclaration(ns.c_str(), context);
+    context = GetOrCreateNamespaceDecl(ns.c_str(), *context);
     name_components = name_components.drop_front();
----------------
amccarth wrote:
> Again, I think you should drop the `.c_str()`.
Disregard this comment.  I was going to make a different suggestion and this was a leftover part of that.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60817/new/

https://reviews.llvm.org/D60817