[Lldb-commits] [PATCH] D60405: MinidumpYAML: Add support for ModuleList stream

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Apr 8 08:07:19 PDT 2019


clayborg added a comment.

LGTM. Probably should get one more ok



================
Comment at: lib/ObjectYAML/MinidumpYAML.cpp:91
+
 size_t BlobAllocator::allocateString(StringRef Str) {
   SmallVector<UTF16, 32> WStr;
----------------
Might be nice to unique the strings in here?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60405/new/

https://reviews.llvm.org/D60405





More information about the lldb-commits mailing list