[Lldb-commits] [PATCH] D60405: MinidumpYAML: Add support for ModuleList stream

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Apr 8 06:15:43 PDT 2019


labath created this revision.
labath added reviewers: amccarth, jhenderson, clayborg, zturner.
Herald added a project: LLVM.

This patch adds support for yaml (de)serialization of the minidump
ModuleList stream. It's a fairly straight forward-application of the
existing patterns to the ModuleList structures defined in previous
patches.

One thing, which may be interesting to call out explicitly is the
addition of "new" allocation functions to the helper BlobAllocator
class. The reason for this was, that there was an emerging pattern of a
need to allocate space for entities, which do not have a suitable
lifetime for use with the existing allocation functions. A typical
example of that was the "size" of various lists, which is only available
as a temporary returned by the .size() method of some container. For
these cases, one can use the new set of allocation functions, which
will take a temporary object, and store it in an allocator-managed
buffer until it is written to disk.


Repository:
  rL LLVM

https://reviews.llvm.org/D60405

Files:
  include/llvm/BinaryFormat/Minidump.h
  include/llvm/Object/Minidump.h
  include/llvm/ObjectYAML/MinidumpYAML.h
  lib/ObjectYAML/MinidumpYAML.cpp
  test/tools/obj2yaml/basic-minidump.yaml

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D60405.194130.patch
Type: text/x-patch
Size: 16636 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190408/9385f165/attachment-0001.bin>


More information about the lldb-commits mailing list