[Lldb-commits] [PATCH] D59433: Fix UUID decoding from minidump files.

Fri Mar 15 15:29:04 PDT 2019

clayborg added a comment.

In D59433#1431488 <https://reviews.llvm.org/D59433#1431488>, @zturner wrote:

> "MinidumpNew" is a little bit vague.  What's "new" about it?  Is there a way we could come up with a better name?

This was an existing file that I just added new tests to, and it seemed to be where most of the minidump tests were.

> As an aside, since there's no interactivity in these tests, they seem like a good candidate for lit/Minidump, with 1 file for each test.  Something like:
> 
>   ; zero-uuid-modules.test
>   ; RUN: lldb -core %S/Inputs/linux-arm-zero-uuids.dmp -S %p | FileCheck %s
>   
>   target modules list
>   
>   ; CHECK: [  0] 00000000-0000-0000-0000-000000000000-00000000                    /tmp/a
>   ; CHECK: [  1] 00000000-0000-0000-0000-000000000000-00000000                    /tmp/b
> 
> 
> Let's see what Pavel thinks though.

I wish the lit tests worked with the Xcode build

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59433/new/

https://reviews.llvm.org/D59433