[Lldb-commits] [PATCH] D59433: Fix UUID decoding from minidump files.

[Zachary Turner via Phabricator via lldb-commits]

zturner added a comment.

"MinidumpNew" is a little bit vague.  What's "new" about it?  Is there a way we could come up with a better name?

As an aside, since there's no interactivity in these tests, they seem like a good candidate for lit/Minidump, with 1 file for each test.  Something like:

  ; zero-uuid-modules.test
  ; RUN: lldb -core %S/Inputs/linux-arm-zero-uuids.dmp -S %p | FileCheck %s
  
  target modules list
  
  ; CHECK: [  0] 00000000-0000-0000-0000-000000000000-00000000                    /tmp/a
  ; CHECK: [  1] 00000000-0000-0000-0000-000000000000-00000000                    /tmp/b

Let's see what Pavel thinks though.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59433/new/

https://reviews.llvm.org/D59433