[Lldb-commits] [PATCH] D58125: Add ability to import std module into expression parser to improve C++ debugging

[Raphael Isemann via Phabricator via lldb-commits]

teemperor updated this revision to Diff 189160.
teemperor added a comment.
Herald added a subscriber: ormris.

- Refactored build flags.
- Fixed doxygen comment.

Yeah, the implicit module map flag wasn't actually necessary for the tests, thanks! For the Makefile, I had to create a utility variable as `-gmodules` shouldn't be necessary for our tests, so the new flags are not really a superset of the normal module flags.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58125/new/

https://reviews.llvm.org/D58125

Files:
  lldb/include/lldb/Expression/ExpressionSourceCode.h
  lldb/include/lldb/Target/Platform.h
  lldb/include/lldb/Target/Target.h
  lldb/packages/Python/lldbsuite/test/expression_command/import-std-module/basic/Makefile
  lldb/packages/Python/lldbsuite/test/expression_command/import-std-module/basic/TestImportStdModule.py
  lldb/packages/Python/lldbsuite/test/expression_command/import-std-module/basic/main.cpp
  lldb/packages/Python/lldbsuite/test/expression_command/import-std-module/conflicts/Makefile
  lldb/packages/Python/lldbsuite/test/expression_command/import-std-module/conflicts/TestStdModuleWithConflicts.py
  lldb/packages/Python/lldbsuite/test/expression_command/import-std-module/conflicts/main.cpp
  lldb/packages/Python/lldbsuite/test/expression_command/import-std-module/no-std-module/Makefile
  lldb/packages/Python/lldbsuite/test/expression_command/import-std-module/no-std-module/TestMissingStdModule.py
  lldb/packages/Python/lldbsuite/test/expression_command/import-std-module/no-std-module/main.cpp
  lldb/packages/Python/lldbsuite/test/expression_command/import-std-module/sysroot/Makefile
  lldb/packages/Python/lldbsuite/test/expression_command/import-std-module/sysroot/TestStdModuleSysroot.py
  lldb/packages/Python/lldbsuite/test/expression_command/import-std-module/sysroot/main.cpp
  lldb/packages/Python/lldbsuite/test/expression_command/import-std-module/sysroot/root/usr/include/c++/include/algorithm
  lldb/packages/Python/lldbsuite/test/expression_command/import-std-module/sysroot/root/usr/include/c++/include/module.modulemap
  lldb/packages/Python/lldbsuite/test/expression_command/import-std-module/sysroot/root/usr/include/libc_header.h
  lldb/packages/Python/lldbsuite/test/make/Makefile.rules
  lldb/source/Expression/ExpressionSourceCode.cpp
  lldb/source/Plugins/ExpressionParser/Clang/ASTUtils.cpp
  lldb/source/Plugins/ExpressionParser/Clang/ASTUtils.h
  lldb/source/Plugins/ExpressionParser/Clang/CMakeLists.txt
  lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
  lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.h
  lldb/source/Plugins/ExpressionParser/Clang/ClangUserExpression.cpp
  lldb/source/Plugins/ExpressionParser/Clang/ClangUserExpression.h
  lldb/source/Plugins/Platform/Linux/PlatformLinux.cpp
  lldb/source/Plugins/Platform/Linux/PlatformLinux.h
  lldb/source/Target/Target.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58125.189160.patch
Type: text/x-patch
Size: 64799 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190304/5b57c438/attachment-0001.bin>