[Lldb-commits] [PATCH] D58125: Add ability to import std module into expression parser to improve C++ debugging

Mon Mar 4 09:01:16 PST 2019

aprantl added inline comments.

================
Comment at: lldb/include/lldb/Target/Platform.h:283
+  ///
+  /// @param[in] lang
+  ///     The language for which the include directories should be queried.
----------------
`\param`

================
Comment at: lldb/packages/Python/lldbsuite/test/make/Makefile.rules:291
+# -glldb is necessary for emitting information about what modules were imported.
+MANDATORY_CXXMODULE_BUILD_CFLAGS := -fmodules -fcxx-modules -fmodules-cache-path=$(CLANG_MODULE_CACHE_DIR) -glldb -fimplicit-module-maps

----------------
`$(MANDATORY_MODULE_BUILD_CFLAG) -cfxx-modules -glldb` ?
Why is -fimplicit-module-maps only on the C++ case?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58125/new/

https://reviews.llvm.org/D58125