[Lldb-commits] [PATCH] D58842: Move ProcessInstanceInfo and similar to Utility

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Mar 1 13:11:15 PST 2019

labath added a comment.

My main reason for creating D58167 <https://reviews.llvm.org/D58167> was so that this move (*) could be done without leaving the remnants of the Dump function in the form DumpProcessInstance functions in Process.cpp (among other benefits I think that refactoring will bring). I still think it would be better to do this in that order, but if takes too long to get that patch accepted (I'm not sure what's the holdup, maybe people just don't care enough about that?), then we can do things in the opposite order too (or just drop the second patch, if noone's interested in it).

(*) I was originally planning to move these into Host (and I have actually already moved some of them recently, which is why some of these classes are in Host and others in Target). I did that because Host already  contains code for working with processes and there's no problem in Target depending on Host, so it was "good enough". However, the case for Utility also sounds reasonable to me, so I am fine with that option too.



More information about the lldb-commits mailing list