[Lldb-commits] [PATCH] D58842: Move ProcessInstanceInfo and similar to Utility

[Zachary Turner via Phabricator via lldb-commits]

zturner created this revision.
zturner added reviewers: jingham, labath, JDevlieghere.
Herald added subscribers: jdoerfert, mgorny, emaste.

There are set of classes in Target that describe the parameters of a process - e.g. it's PID, name, user id, and similar.  However, since it is a bare description of a process and contains no actual functionality, there's nothing specifically that makes this appropriate for being in Target -- it could just as well be describing a process on the host, or some hypothetical virtual process that doesn't even exist.

To cement this, I'm moving this class to Utility.  It's possible that we can find a better place for it in the future, but as it is neither Host specific nor Target specific, Utility seems like the most appropriate place for the time being.

After this there are only 2 remaining references to Target from Host, neither of which is terribly difficult to fix on its own and which I'll address in followups.


https://reviews.llvm.org/D58842

Files:
  lldb/include/lldb/Host/Host.h
  lldb/include/lldb/Host/ProcessInfo.h
  lldb/include/lldb/Host/ProcessLaunchInfo.h
  lldb/include/lldb/Target/Platform.h
  lldb/include/lldb/Target/Process.h
  lldb/include/lldb/Utility/ProcessInfo.h
  lldb/include/lldb/module.modulemap
  lldb/source/API/SBProcess.cpp
  lldb/source/API/SBProcessInfo.cpp
  lldb/source/API/SBTarget.cpp
  lldb/source/Commands/CommandObjectPlatform.cpp
  lldb/source/Host/CMakeLists.txt
  lldb/source/Host/common/ProcessInfo.cpp
  lldb/source/Host/freebsd/Host.cpp
  lldb/source/Host/linux/Host.cpp
  lldb/source/Host/netbsd/Host.cpp
  lldb/source/Host/openbsd/Host.cpp
  lldb/source/Host/windows/Host.cpp
  lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp
  lldb/source/Plugins/Platform/MacOSX/PlatformAppleTVSimulator.cpp
  lldb/source/Plugins/Platform/MacOSX/PlatformAppleWatchSimulator.cpp
  lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp
  lldb/source/Plugins/Platform/MacOSX/PlatformiOSSimulator.cpp
  lldb/source/Plugins/Platform/gdb-server/PlatformRemoteGDBServer.cpp
  lldb/source/Target/Process.cpp
  lldb/source/Utility/CMakeLists.txt
  lldb/source/Utility/ProcessInfo.cpp
  lldb/unittests/Host/CMakeLists.txt
  lldb/unittests/Host/ProcessInfoTest.cpp
  lldb/unittests/Utility/CMakeLists.txt
  lldb/unittests/Utility/ProcessInfoTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58842.188950.patch
Type: text/x-patch
Size: 46970 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190301/8928dadf/attachment-0001.bin>