[Lldb-commits] [PATCH] D57990: Use std::make_shared in LLDB (NFC)

Eugene Zelenko via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Feb 8 17:54:21 PST 2019


Eugene.Zelenko added inline comments.


================
Comment at: lldb/source/API/SBData.cpp:9
 
 #include <inttypes.h>
 
----------------
cinttypes should be used instead. See Clang-tidy modernize-deprecated-headers. Same in other places.


================
Comment at: lldb/source/API/SBData.cpp:12
+#include <memory>
+
 #include "lldb/API/SBData.h"
----------------
Spaces between include statements interfere with Clang-format. Same in other places.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57990/new/

https://reviews.llvm.org/D57990





More information about the lldb-commits mailing list