[Lldb-commits] [PATCH] D57964: Fix potential UB when target_file directory is null
Jim Ingham via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Fri Feb 8 11:14:42 PST 2019
jingham added a comment.
Might be clearer to do:
if (target_file.GetDirectory().IsEmpty()) {
error...
}
std::string directory = ...
Avoids the extra variable and also adds the check for "", which I don't think we want to add to sys.path either.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57964/new/
https://reviews.llvm.org/D57964
More information about the lldb-commits
mailing list