[Lldb-commits] [PATCH] D57959: [lldb] [MainLoop] Initialize empty sigset_t correctly

Kamil Rytarowski via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Feb 8 11:00:36 PST 2019


krytarowski added inline comments.


================
Comment at: lldb/source/Host/common/MainLoop.cpp:149
   for (const auto &sig : loop.m_signals)
     sigdelset(&sigmask, sig.first);
 #endif
----------------
krytarowski wrote:
> Shouldn't we initialize sigmask always before adding/deleting particular signals?
Ah, I can see it now. It's passed to `pthread_sigmask(3)` so it's fine.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57959/new/

https://reviews.llvm.org/D57959





More information about the lldb-commits mailing list