[Lldb-commits] [lldb] r353468 - Silence fallthrough warnings in debugserver.

Adrian Prantl via lldb-commits lldb-commits at lists.llvm.org
Thu Feb 7 13:22:38 PST 2019


Author: adrian
Date: Thu Feb  7 13:22:38 2019
New Revision: 353468

URL: http://llvm.org/viewvc/llvm-project?rev=353468&view=rev
Log:
Silence fallthrough warnings in debugserver.

Modified:
    lldb/trunk/include/lldb/module.modulemap
    lldb/trunk/tools/debugserver/source/debugserver.cpp

Modified: lldb/trunk/include/lldb/module.modulemap
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/module.modulemap?rev=353468&r1=353467&r2=353468&view=diff
==============================================================================
--- lldb/trunk/include/lldb/module.modulemap (original)
+++ lldb/trunk/include/lldb/module.modulemap Thu Feb  7 13:22:38 2019
@@ -47,7 +47,7 @@ module lldb_Host {
   module SafeMachO { header "Host/SafeMachO.h" export * }
   module SocketAddress { header "Host/SocketAddress.h" export * }
   module Socket { header "Host/Socket.h" export * }
-  module StringConvert { header "Host/StringConvert.h" export * }
+  module StringConvert { textual header "Host/StringConvert.h" export * }
   module Symbols { header "Host/Symbols.h" export * }
   module TaskPool { header "Host/TaskPool.h" export * }
   module Terminal { header "Host/Terminal.h" export * }

Modified: lldb/trunk/tools/debugserver/source/debugserver.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/debugserver/source/debugserver.cpp?rev=353468&r1=353467&r2=353468&view=diff
==============================================================================
--- lldb/trunk/tools/debugserver/source/debugserver.cpp (original)
+++ lldb/trunk/tools/debugserver/source/debugserver.cpp Thu Feb  7 13:22:38 2019
@@ -492,6 +492,7 @@ RNBRunLoopMode HandleProcessStateChange(
 
   case eStateExited:
     remote->HandlePacket_last_signal(NULL);
+    return eRNBRunLoopModeExit;
   case eStateDetached:
     return eRNBRunLoopModeExit;
   }
@@ -1000,7 +1001,8 @@ int main(int argc, char *argv[]) {
 
       case optional_argument:
         short_options[short_options_idx++] = ':';
-      // Fall through to required_argument case below...
+        short_options[short_options_idx++] = ':';
+        break;
       case required_argument:
         short_options[short_options_idx++] = ':';
         break;
@@ -1670,6 +1672,7 @@ int main(int argc, char *argv[]) {
 
     default:
       mode = eRNBRunLoopModeExit;
+      break;
     case eRNBRunLoopModeExit:
       break;
     }




More information about the lldb-commits mailing list