[Lldb-commits] [PATCH] D57402: build: remove custom variables

[Stefan Gränitz via Phabricator via lldb-commits]

sgraenitz added a comment.

> it is pretty reasonable to ask that the user tell us where LLVM and Clang are built

Yes, and `Clang_DIR` should default to the build-/install-tree specified via `LLVM_DIR`. In the vast majority of cases we build against one tree that has both, Clang and LLVM. If we then pass `-DLLVM_DIR=/path/to/llvm-build-root/lib/cmake/llvm`, I think we should not need to pass `-DClang_DIR=/path/to/llvm-build-root/lib/cmake/clang` explicitly. `LLDB_PATH_TO_CLANG_BUILD` so far defaults to `LLDB_PATH_TO_LLVM_BUILD` and both of them would have a path like `/path/to/llvm-build-root`. This behavior should be preserved, but I don't see how it works in the new version. Note that the path expected for `LLVM_DIR` is "the directory where LLVMConfig.cmake is found" (https://llvm.org/docs/CMake.html#embedding-llvm-in-your-project), which is different from the one we used to pass to `LLDB_PATH_TO_LLVM_BUILD`.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57402/new/

https://reviews.llvm.org/D57402