[Lldb-commits] [PATCH] D56595: SymbolFileBreakpad: Add line table support

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Feb 6 07:24:13 PST 2019


clayborg added a comment.

Just bounds check "index" in parse compile unit and this is good to go



================
Comment at: source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp:196
+
+  CompUnitData &data = m_cu_data->GetEntryRef(index).data;
+
----------------
Validate "index" first? We will crash if someone iterates over too many CUs?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56595/new/

https://reviews.llvm.org/D56595





More information about the lldb-commits mailing list