[Lldb-commits] [PATCH] D57751: minidump: Add ability to attach (breakpad) symbol files to placeholder modules

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Feb 6 02:31:16 PST 2019


labath updated this revision to Diff 185513.
labath marked 8 inline comments as done.
labath added a comment.

- remove std::move
- avoid using the word "update" in CreateModuleFromObjectFile
- implement the Dump method and cover it with a test


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57751/new/

https://reviews.llvm.org/D57751

Files:
  include/lldb/Core/Module.h
  lit/Minidump/Inputs/linux-x86_64.dmp
  lit/Minidump/Inputs/linux-x86_64.syms
  lit/Minidump/breakpad-symbols.test
  source/Plugins/Process/minidump/ProcessMinidump.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D57751.185513.patch
Type: text/x-patch
Size: 9420 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190206/aa23f0bd/attachment-0001.bin>


More information about the lldb-commits mailing list