[Lldb-commits] [PATCH] D57402: build: remove custom variables

Wed Feb 6 02:24:14 PST 2019

sgraenitz added a comment.

In D57402#1385718 <https://reviews.llvm.org/D57402#1385718>, @xiaobai wrote:

> > - For us it's a good match for our downstream code https://github.com/apple/swift-lldb/blob/upstream-with-swift/cmake/modules/LLDBStandalone.cmake
>
> I don't think it's too difficult to change how it works downstream in lldb-swift. I actually already have an open PR trying to make swift-lldb closer to upstream in this particular file: https://github.com/apple/swift-lldb/pull/1252
>  This change would be a cherry-pick on top of that, I think.

Ok didn't see this PR earlier either. Will have a look.

> The consequence of this is that you would be required to specify Clang_DIR unless a clang install is in your `CMAKE_MODULE_PATH`. I assume @compnerd specified Clang_DIR when he tested this patch.

@compnerd can you please confirm/clarify? By default we shouldn't need to specify Clang_DIR explicitly. Otherwise LGTM.

Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57402/new/

https://reviews.llvm.org/D57402