[Lldb-commits] [PATCH] D57552: Handle "." in target.source-map in PathMapListing::FindFiles

Jim Ingham via lldb-commits lldb-commits at lists.llvm.org
Tue Feb 5 16:52:44 PST 2019


Oh, wait.  I forgot to svn add the directory in which I was hiding the source file.  I did that in r353251.  Let's see if that works any better!

Jim


> On Feb 5, 2019, at 4:42 PM, Jim Ingham <jingham at apple.com> wrote:
> 
> I don't have the ability to debug this and the test output isn't very helpful.   There's very little chance what this is testing was working on Windows before this patch, as the relative case was unhandled...  So I don't think this patch makes things worse.  If somebody who has a windows machine available wants to try to debug the windows side of this, that would be great!
> 
> Give me just a minute and I'll split the test into a part that does the path remap and a part that tests we can find the file and xfail the latter on windows. 
> 
> Jim
> 
> 
>> On Feb 5, 2019, at 4:30 PM, Stella Stamenova via Phabricator <reviews at reviews.llvm.org> wrote:
>> 
>> stella.stamenova added a comment.
>> 
>> This is failing on the windows bot:
>> 
>> http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/1379
>> 
>> 
>> Repository:
>> rL LLVM
>> 
>> CHANGES SINCE LAST ACTION
>> https://reviews.llvm.org/D57552/new/
>> 
>> https://reviews.llvm.org/D57552
>> 
>> 
>> 
> 



More information about the lldb-commits mailing list