[Lldb-commits] [PATCH] D57780: Don't include UnixSignals.h from Host

[Zachary Turner via Phabricator via lldb-commits]

zturner created this revision.
zturner added a reviewer: labath.
Herald added a reviewer: jfb.

This file lives in Target, which makes sense since it is supposed to represent the various types of signals that can occur on any platform (since you might be remote debugging a platform with different signals than the host).

However, Host had a method called `GetUnixSignals` which just returned an instance of this class initialized for the Host's signals.  Rather than have this functionality in Host, we can just provide a static factory method on `UnixSignals` called `CreateForHost`.  This brings us one step closer to breaking the Target -> Host -> Target cycle.


https://reviews.llvm.org/D57780

Files:
  lldb/include/lldb/Host/Host.h
  lldb/include/lldb/Target/Platform.h
  lldb/include/lldb/Target/UnixSignals.h
  lldb/source/Host/common/Host.cpp
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.cpp
  lldb/source/Target/Platform.cpp
  lldb/source/Target/UnixSignals.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D57780.185379.patch
Type: text/x-patch
Size: 4313 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190205/87eee1f4/attachment.bin>