[Lldb-commits] [PATCH] D57552: Handle "." in target.source-map in PathMapListing::FindFiles

[Jim Ingham via Phabricator via lldb-commits]

jingham marked an inline comment as done.
jingham added inline comments.


================
Comment at: source/Target/PathMappingList.cpp:223
+      
+      if (prefix_ref == ".") {
+        prefix_is_relative = true;
----------------
clayborg wrote:
> We are we finding a "." in any path now? I thought we normalized those all out? Can a PathMappingList contain non normalized paths? if so, can't we just normalize them as they go into the list?
That's the incoming path from the path maps.  You can't normalize just a "." from the path mappings or it would become "" and we don't really know what that means.  These are currently left as ".".  I think that's right.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57552/new/

https://reviews.llvm.org/D57552