[Lldb-commits] [PATCH] D56418: Change lldb-test to use ParseAllDebugSymbols instead of ParseDeclsForContext

[Pavel Labath via lldb-commits]

On 08/01/2019 11:45, Zachary Turner wrote:
> The same plugin is being used in both cases, the patch only touches the 
> nonnative PDB reader. The followup changes to the plugin itself are 
> necessary because the results were not identical (another reason i want 
> to de-support ParseDeclsForContext at global acope - having 2 
> implementations of the same thing means they will differ slightly).
> 
> In this case it happened that the ParseAllDebugSymbolsPath reconstructed 
> both the lldb type hierarchy and the clang ast hierarchy, but the 
> ParseAllDebugSymbols path missed a few things in the clang ast hierarchy )
> 
> The changes to the test that you see are because the two paths — even 
> though they’re still in the same plugin — result in things being 
> constructed in a different order

Ok, that makes sense. Thanks.