[Lldb-commits] [PATCH] D56418: Change lldb-test to use ParseAllDebugSymbols instead of ParseDeclsForContext

[Zachary Turner via lldb-commits]

The same plugin is being used in both cases, the patch only touches the
nonnative PDB reader. The followup changes to the plugin itself are
necessary because the results were not identical (another reason i want to
de-support ParseDeclsForContext at global acope - having 2 implementations
of the same thing means they will differ slightly).

In this case it happened that the ParseAllDebugSymbolsPath reconstructed
both the lldb type hierarchy and the clang ast hierarchy, but the
ParseAllDebugSymbols path missed a few things in the clang ast hierarchy )

The changes to the test that you see are because the two paths — even
though they’re still in the same plugin — result in things being
constructed in a different order
On Tue, Jan 8, 2019 at 2:38 AM Pavel Labath via Phabricator <
reviews at reviews.llvm.org> wrote:

> labath accepted this revision.
> labath added a comment.
> This revision is now accepted and ready to land.
>
> The lldb-test change itself looks fine. I don't feel like I know the full
> impact of the proposed follow-up changes (but they sounds reasonable).
>
>
>
> ================
> Comment at: lldb/lit/SymbolFile/PDB/enums-layout.test:3
>  RUN: %build --compiler=msvc --arch=32 --nodefaultlib
> --output=%T/SimpleTypesTest.cpp.enums.exe %S/Inputs/SimpleTypesTest.cpp
> -RUN: lldb-test symbols %T/SimpleTypesTest.cpp.enums.exe | FileCheck %s
> +RUN: lldb-test symbols %T/SimpleTypesTest.cpp.enums.exe | FileCheck
> --check-prefix=ENUM %s
> +RUN: lldb-test symbols %T/SimpleTypesTest.cpp.enums.exe | FileCheck
> --check-prefix=ENUM_CONST %s
> ----------------
> I guess this is because the order in the two plugins ends up being
> different?
>
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D56418/new/
>
> https://reviews.llvm.org/D56418
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190108/cd36df9c/attachment.html>