[Lldb-commits] [PATCH] D56400: [CMake] Some cleanup around test preparations
Pavel Labath via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Jan 8 02:29:38 PST 2019
labath added a reviewer: stella.stamenova.
labath added a comment.
This looks fine to me. I recommend including Stella in changes relating to this, as I recall some subtleties here wrt. multi-config (e.g., MSVC) generators.
Comment at: CMakeLists.txt:43
+ # FIXME: LLDB_TEST_CXX_COMPILER is unused.
+ # FIXME: In standalone builds LLVM_BINARY_DIR points to LLDB's build directory and not to LLVM's!
> Why is this unused? Are we only using `LLDB_TEST_C_COMPILER` and if so, why?
I think that's because this only gets passed to dotest, that it has it's own logic for deducing the C++ compiler name.
CHANGES SINCE LAST ACTION
More information about the lldb-commits