[Lldb-commits] [PATCH] D56400: [CMake] Some cleanup around test preparations

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added inline comments.


================
Comment at: CMakeLists.txt:43
 if(LLDB_INCLUDE_TESTS)
+  # FIXME: LLDB_TEST_CXX_COMPILER is unused.
+  # FIXME: In standalone builds LLVM_BINARY_DIR points to LLDB's build directory and not to LLVM's!
----------------
Why is this unused? Are we only using `LLDB_TEST_C_COMPILER` and if so, why?


================
Comment at: CMakeLists.txt:44
+  # FIXME: LLDB_TEST_CXX_COMPILER is unused.
+  # FIXME: In standalone builds LLVM_BINARY_DIR points to LLDB's build directory and not to LLVM's!
+  # FIXME: LLDB_TEST_USE_CUSTOM_C/CXX_COMPILER options don't work as intended!
----------------
sgraenitz wrote:
> This was here already when the file was created:
> https://github.com/llvm-mirror/lldb/blob/98c187f2613fd8e2f5cdf5f8f35503a102a54f11/cmake/modules/LLDBStandalone.cmake#L67
> 
> Apparently the below default paths for dsymutil, FileCheck and clang never worked in standalone builds..
Instead of this FIXME, should we explicitly unset this variable to prevent mistakes in the future? Or is this fixable?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56400/new/

https://reviews.llvm.org/D56400