[Lldb-commits] [PATCH] D55240: [FileSystem] Migrate CommandCompletions

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere marked an inline comment as done.
JDevlieghere added inline comments.


================
Comment at: source/Commands/CommandCompletions.cpp:180
 
+  FileSystem fs = FileSystem::Instance();
   std::error_code EC;
----------------
labath wrote:
> This should surely be a reference, no? Making a copy of a filesystem sounds weird (and should probably be forbidden by deleting the copy constructor).
Correct, this is a typo but shouldn't compile. I'll include the fix when landing.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55240/new/

https://reviews.llvm.org/D55240