[Lldb-commits] [PATCH] D55240: [FileSystem] Migrate CommandCompletions
Jonas Devlieghere via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Dec 4 09:34:08 PST 2018
JDevlieghere marked an inline comment as done.
JDevlieghere added inline comments.
Comment at: source/Commands/CommandCompletions.cpp:180
+ FileSystem fs = FileSystem::Instance();
> This should surely be a reference, no? Making a copy of a filesystem sounds weird (and should probably be forbidden by deleting the copy constructor).
Correct, this is a typo but shouldn't compile. I'll include the fix when landing.
CHANGES SINCE LAST ACTION
More information about the lldb-commits