[Lldb-commits] [PATCH] D55240: [FileSystem] Migrate CommandCompletions

[Pavel Labath via Phabricator via lldb-commits]

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

Looks good, modulo the filesystem copy comment.



================
Comment at: source/Commands/CommandCompletions.cpp:180
 
+  FileSystem fs = FileSystem::Instance();
   std::error_code EC;
----------------
This should surely be a reference, no? Making a copy of a filesystem sounds weird (and should probably be forbidden by deleting the copy constructor).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55240/new/

https://reviews.llvm.org/D55240