[Lldb-commits] [PATCH] D54914: Add a generic build script for building test inferiors

[Zachary Turner via lldb-commits]

I can repro this, so I'll work on a fix.

On Wed, Nov 28, 2018 at 12:38 PM Stella Stamenova via Phabricator <
reviews at reviews.llvm.org> wrote:

> stella.stamenova added a comment.
>
> I ran the tests with this change and there are about a dozen new failures:
>
>   2018-11-28T20:25:29.2437909Z          ********************
>   2018-11-28T20:25:29.2581909Z          FAIL: LLDB ::
> SymbolFile/NativePDB/function-types-builtins.cpp (16962 of 45532)
>   2018-11-28T20:25:29.2593650Z          ******************** TEST 'LLDB ::
> SymbolFile/NativePDB/function-types-builtins.cpp' FAILED
> ********************
>   2018-11-28T20:25:29.2627299Z          Script:
>   2018-11-28T20:25:29.2627541Z          --
>   2018-11-28T20:25:29.2628080Z          : 'RUN: at line 4';   C:\Program
> Files (x86)\Microsoft Visual Studio\Shared\Python36_64\python.exe
> E:\_work\80\s\llvm\tools\lldb\lit\helper\build.py --compiler=any --arch=64
> --tools-dir=E:/_work/80/b/LLVMBuild/Release/bin --compiler=clang-cl
> --nodefaultlib -o
> E:\_work\80\b\LLVMBuild\tools\lldb\lit\SymbolFile\NativePDB\Output\function-types-builtins.cpp.tmp.exe
> --
> E:\_work\80\s\llvm\tools\lldb\lit\SymbolFile\NativePDB\function-types-builtins.cpp
>   2018-11-28T20:25:29.2629494Z          : 'RUN: at line 5';   env
> LLDB_USE_NATIVE_PDB_READER=1 E:\_work\80\b\LLVMBuild\Release\bin\lldb.EXE
> -S E:/_work/80/s/llvm/tools/lldb/lit\lit-lldb-init -f
> E:\_work\80\b\LLVMBuild\tools\lldb\lit\SymbolFile\NativePDB\Output\function-types-builtins.cpp.tmp.exe
> -s
> E:\_work\80\s\llvm\tools\lldb\lit\SymbolFile\NativePDB/Inputs/function-types-builtins.lldbinit
> | E:\_work\80\b\LLVMBuild\Release\bin\FileCheck.EXE
> E:\_work\80\s\llvm\tools\lldb\lit\SymbolFile\NativePDB\function-types-builtins.cpp
>   2018-11-28T20:25:29.2629805Z          --
>   2018-11-28T20:25:29.2629901Z          Exit Code: 127
>   2018-11-28T20:25:29.2630016Z
>   2018-11-28T20:25:29.2630140Z          Command Output (stdout):
>   2018-11-28T20:25:29.2630258Z          --
>   2018-11-28T20:25:29.2630427Z          $ ":" "RUN: at line 4"
>   2018-11-28T20:25:29.2630915Z          $ "C:\Program" "Files"
> "(x86)\Microsoft" "Visual" "Studio\Shared\Python36_64\python.exe"
> "E:\_work\80\s\llvm\tools\lldb\lit\helper\build.py" "--compiler=any"
> "--arch=64" "--tools-dir=E:/_work/80/b/LLVMBuild/Release/bin"
> "--compiler=clang-cl" "--nodefaultlib" "-o"
> "E:\_work\80\b\LLVMBuild\tools\lldb\lit\SymbolFile\NativePDB\Output\function-types-builtins.cpp.tmp.exe"
> "--"
> "E:\_work\80\s\llvm\tools\lldb\lit\SymbolFile\NativePDB\function-types-builtins.cpp"
>   2018-11-28T20:25:29.2631273Z          # command stderr:
>   2018-11-28T20:25:29.2631382Z          'C:\\Program': command not found
>
> It looks like the script doesn't handle paths that have spaces correctly.
> I think the issue is on line 45 where we add sys.executable as the command
> - we need quotes around that. I'm going to rerun the tests with that change
> to see the result.
>
>
>
> ================
> Comment at: lldb/lit/helper/toolchain.py:45
> +        ToolSubst('%build',
> +                  command=sys.executable,
> +                  extra_args=build_script_args)
> ----------------
> I think this is where we need quotes around sys.executable, so that if the
> path contains spaces it is handled correctly
>
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D54914/new/
>
> https://reviews.llvm.org/D54914
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20181128/ca648586/attachment.html>