<div dir="ltr">I can repro this, so I'll work on a fix.</div><br><div class="gmail_quote"><div dir="ltr">On Wed, Nov 28, 2018 at 12:38 PM Stella Stamenova via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">stella.stamenova added a comment.<br>
<br>
I ran the tests with this change and there are about a dozen new failures:<br>
<br>
  2018-11-28T20:25:29.2437909Z          ********************<br>
  2018-11-28T20:25:29.2581909Z          FAIL: LLDB :: SymbolFile/NativePDB/function-types-builtins.cpp (16962 of 45532)<br>
  2018-11-28T20:25:29.2593650Z          ******************** TEST 'LLDB :: SymbolFile/NativePDB/function-types-builtins.cpp' FAILED ********************<br>
  2018-11-28T20:25:29.2627299Z          Script:<br>
  2018-11-28T20:25:29.2627541Z          --<br>
  2018-11-28T20:25:29.2628080Z          : 'RUN: at line 4';   C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python36_64\python.exe E:\_work\80\s\llvm\tools\lldb\lit\helper\build.py --compiler=any --arch=64 --tools-dir=E:/_work/80/b/LLVMBuild/Release/bin --compiler=clang-cl --nodefaultlib -o E:\_work\80\b\LLVMBuild\tools\lldb\lit\SymbolFile\NativePDB\Output\function-types-builtins.cpp.tmp.exe -- E:\_work\80\s\llvm\tools\lldb\lit\SymbolFile\NativePDB\function-types-builtins.cpp<br>
  2018-11-28T20:25:29.2629494Z          : 'RUN: at line 5';   env LLDB_USE_NATIVE_PDB_READER=1 E:\_work\80\b\LLVMBuild\Release\bin\lldb.EXE -S E:/_work/80/s/llvm/tools/lldb/lit\lit-lldb-init -f E:\_work\80\b\LLVMBuild\tools\lldb\lit\SymbolFile\NativePDB\Output\function-types-builtins.cpp.tmp.exe -s      E:\_work\80\s\llvm\tools\lldb\lit\SymbolFile\NativePDB/Inputs/function-types-builtins.lldbinit | E:\_work\80\b\LLVMBuild\Release\bin\FileCheck.EXE E:\_work\80\s\llvm\tools\lldb\lit\SymbolFile\NativePDB\function-types-builtins.cpp<br>
  2018-11-28T20:25:29.2629805Z          --<br>
  2018-11-28T20:25:29.2629901Z          Exit Code: 127<br>
  2018-11-28T20:25:29.2630016Z          <br>
  2018-11-28T20:25:29.2630140Z          Command Output (stdout):<br>
  2018-11-28T20:25:29.2630258Z          --<br>
  2018-11-28T20:25:29.2630427Z          $ ":" "RUN: at line 4"<br>
  2018-11-28T20:25:29.2630915Z          $ "C:\Program" "Files" "(x86)\Microsoft" "Visual" "Studio\Shared\Python36_64\python.exe" "E:\_work\80\s\llvm\tools\lldb\lit\helper\build.py" "--compiler=any" "--arch=64" "--tools-dir=E:/_work/80/b/LLVMBuild/Release/bin" "--compiler=clang-cl" "--nodefaultlib" "-o" "E:\_work\80\b\LLVMBuild\tools\lldb\lit\SymbolFile\NativePDB\Output\function-types-builtins.cpp.tmp.exe" "--" "E:\_work\80\s\llvm\tools\lldb\lit\SymbolFile\NativePDB\function-types-builtins.cpp"<br>
  2018-11-28T20:25:29.2631273Z          # command stderr:<br>
  2018-11-28T20:25:29.2631382Z          'C:\\Program': command not found<br>
<br>
It looks like the script doesn't handle paths that have spaces correctly. I think the issue is on line 45 where we add sys.executable as the command - we need quotes around that. I'm going to rerun the tests with that change to see the result.<br>
<br>
<br>
<br>
================<br>
Comment at: lldb/lit/helper/toolchain.py:45<br>
+        ToolSubst('%build',<br>
+                  command=sys.executable,<br>
+                  extra_args=build_script_args)<br>
----------------<br>
I think this is where we need quotes around sys.executable, so that if the path contains spaces it is handled correctly<br>
<br>
<br>
CHANGES SINCE LAST ACTION<br>
  <a href="https://reviews.llvm.org/D54914/new/" rel="noreferrer" target="_blank">https://reviews.llvm.org/D54914/new/</a><br>
<br>
<a href="https://reviews.llvm.org/D54914" rel="noreferrer" target="_blank">https://reviews.llvm.org/D54914</a><br>
<br>
<br>
<br>
</blockquote></div>