[Lldb-commits] [PATCH] D54808: [lit] Add pthread to the compilation of the tests on Linux

[Zachary Turner via lldb-commits]

Lgtm
On Wed, Nov 21, 2018 at 12:10 PM Stella Stamenova via Phabricator <
reviews at reviews.llvm.org> wrote:

> stella.stamenova created this revision.
> stella.stamenova added reviewers: labath, zturner, asmith.
> Herald added subscribers: lldb-commits, jfb.
>
> Right now only some platforms add pthread to the compilation, however, at
> least one of the tests requires the pthread library on Linux as well. Since
> the library is available, this change adds it by default on Linux.
>
>
> Repository:
>   rLLDB LLDB
>
> https://reviews.llvm.org/D54808
>
> Files:
>   lit/helper/toolchain.py
>
>
> Index: lit/helper/toolchain.py
> ===================================================================
> --- lit/helper/toolchain.py
> +++ lit/helper/toolchain.py
> @@ -78,7 +78,7 @@
>              sdk_path = lit.util.to_string(out)
>              lit_config.note('using SDKROOT: %r' % sdk_path)
>              flags = ['-isysroot', sdk_path]
> -    elif platform.system() in ['OpenBSD']:
> +    elif platform.system() in ['OpenBSD', 'Linux']:
>          flags = ['-pthread']
>
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20181121/650d7204/attachment.html>