Lgtm<br><div class="gmail_quote"><div dir="ltr">On Wed, Nov 21, 2018 at 12:10 PM Stella Stamenova via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">stella.stamenova created this revision.<br>
stella.stamenova added reviewers: labath, zturner, asmith.<br>
Herald added subscribers: lldb-commits, jfb.<br>
<br>
Right now only some platforms add pthread to the compilation, however, at least one of the tests requires the pthread library on Linux as well. Since the library is available, this change adds it by default on Linux.<br>
<br>
<br>
Repository:<br>
rLLDB LLDB<br>
<br>
<a href="https://reviews.llvm.org/D54808" rel="noreferrer" target="_blank">https://reviews.llvm.org/D54808</a><br>
<br>
Files:<br>
lit/helper/toolchain.py<br>
<br>
<br>
Index: lit/helper/toolchain.py<br>
===================================================================<br>
--- lit/helper/toolchain.py<br>
+++ lit/helper/toolchain.py<br>
@@ -78,7 +78,7 @@<br>
sdk_path = lit.util.to_string(out)<br>
lit_config.note('using SDKROOT: %r' % sdk_path)<br>
flags = ['-isysroot', sdk_path]<br>
- elif platform.system() in ['OpenBSD']:<br>
+ elif platform.system() in ['OpenBSD', 'Linux']:<br>
flags = ['-pthread']<br>
<br>
<br>
<br>
<br>
</blockquote></div>