[Lldb-commits] [PATCH] D54567: Fix LLDB's lit files

[Zachary Turner via Phabricator via lldb-commits]

zturner added a comment.

In https://reviews.llvm.org/D54567#1299982, @aprantl wrote:

> > Removal of functionality - The lit test suite no longer respects LLDB_TEST_C_COMPILER and LLDB_TEST_CXX_COMPILER. This means there is no more support for gcc, but nobody was using this anyway (note: The functionality is still there for the dotest suite, just not the lit test suite).
>
> The "nobody is using this part" of that statement is just not true.
>
> On green dragon, we have two bots that use LLDB_TEST_C_COMPILER / LLDB_TEST_CXX_COMPILER that run the LLDB testsuite against older versions of clang:
>  http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-clang-5.0.2/
>  http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-clang-6.0.1/


It's possible I didn't make this part clear enough.  I didn't mean that nobody is using `LLDB_TEST_C_COMPILER`, I meant that nobody is using it **in order to compile inferiors with gcc**.  There is also a dichotomy between what happens for the dotest suite and the lit suite.  For the dotest suite, `LLDB_TEST_C(XX)_COMPILER` are still respected, this patch hasn't changed that.  It has only changed the behavior of running tests in `lldb/lit/{Breakpoint/Expr/Modules/Quit/Settings/SymbolFile/tools}`.  Even for those tests, it is still possible to use a not-just-built clang, just that instead of specifying `LLDB_TEST_C(XX)_COMPILER`, you now specify `LLDB_LIT_TOOLS_DIR`.


https://reviews.llvm.org/D54567