[Lldb-commits] [PATCH] D54567: Fix LLDB's lit files

Stella Stamenova via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Nov 15 08:59:56 PST 2018

stella.stamenova added a comment.

In https://reviews.llvm.org/D54567#1299992, @aprantl wrote:

> In https://reviews.llvm.org/D54567#1299989, @stella.stamenova wrote:
> > We should also remove LLDB_TEST_C_COMPILER and LLDB_TEST_CXX_COMPILER from the cmake files along with this change, otherwise, people will still expect them to work.
> That would not be a good idea. There are several bots that are using these flags.

The change that Zachary is making is removing their usage, so after his change they would not do anything. If he ends up committing this change, these two properties (along with LLDB_DEFAULT_TEST_C_COMPILER and LLDB_TEST_USE_CUSTOM_C_COMPILER, etc.) should also go.


More information about the lldb-commits mailing list