[Lldb-commits] [PATCH] D54476: [CMake] Streamline code signing for debugserver

Alex Langford via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Nov 13 11:08:37 PST 2018

xiaobai added inline comments.

Comment at: tools/debugserver/source/CMakeLists.txt:128-133
+    # TODO: Following the old behavior, DEBUGSERVER_PATH still points to the
+    # original system binary, even if we copy it over. Keep this?
+    set(DEBUGSERVER_PATH "${lldb_framework_dir}/LLDB.framework/Resources/debugserver" CACHE FILEPATH "" FORCE)
+    # If we haven't built a signed debugserver. If possible, copy the one from
+    # the system to make the built debugger functional on Darwin.
I'm pretty sure that if you do not copy debugserver it will still find the one from your `${lldb_framework_dir}` when you run lldb anyway. Do you know why we copy it over?


More information about the lldb-commits mailing list