[Lldb-commits] [PATCH] D54476: [CMake] Streamline code signing for debugserver

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Nov 13 10:18:49 PST 2018

JDevlieghere added inline comments.

Comment at: tools/debugserver/source/CMakeLists.txt:101
+option(LLDB_NO_DEBUGSERVER "Delete debugserver after building it, and don't try to codesign it" OFF)
+option(LLDB_USE_SYSTEM_DEBUGSERVER "Neither build nor codesign debugserver. Use the system's debugserver instead (Darwin only)." OFF)
Should we emit and error if these variables are in an inconsistent state, e.g. when both are set? 

Comment at: tools/debugserver/source/CMakeLists.txt:118
+      OUTPUT_VARIABLE xcode_dev_dir)
+    string(STRIP ${xcode_dev_dir} xcode_dev_dir)
Why did you make this variable name lowercase? Does that have any semantic meaning?


More information about the lldb-commits mailing list