[Lldb-commits] [PATCH] D54241: Fix bug in printing ValueObjects and in PE/COFF Plugin

[Greg Clayton via Phabricator via lldb-commits]

clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.

Very close, just use the layout type as mentioned in the inline comment.



================
Comment at: lldb/source/Core/ValueObjectVariable.cpp:70
   if (var_type)
-    return var_type->GetForwardCompilerType();
+    return var_type->GetFullCompilerType();
   return CompilerType();
----------------
Change this to GetLayoutCompilerType(). Why? If you have just a class Foo and your variable's type is "Foo *", then you don't need to complete it. The layout type gets you the type that is needed in order to display the current variable. For enums this will do the right thing. Otherwise if you have 1000 variables that are all pointers, you will be completing all of the class types for no reason.


https://reviews.llvm.org/D54241