[Lldb-commits] [PATCH] D54241: Fix bug in printing ValueObjects and in PE/COFF Plugin

Zachary Turner via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Nov 7 17:37:24 PST 2018


zturner updated this revision to Diff 173103.
zturner added a comment.

I actually found an even better fix for this.  LLDB sections already have the notion of "zero fill sections", we just need to mark the `.data` section as a zero fill section in this condition.  No need to override `ReadSectionData`


https://reviews.llvm.org/D54241

Files:
  lldb/lit/SymbolFile/NativePDB/Inputs/globals-bss.lldbinit
  lldb/lit/SymbolFile/NativePDB/ast-reconstruction.cpp
  lldb/lit/SymbolFile/NativePDB/globals-bss.cpp
  lldb/source/Core/ValueObjectVariable.cpp
  lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54241.173103.patch
Type: text/x-patch
Size: 5253 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20181108/fa3916e3/attachment.bin>


More information about the lldb-commits mailing list