[Lldb-commits] [PATCH] D53175: [dotest] Make a missing FileCheck binary a warning, not an error

[Vedant Kumar via lldb-commits]

It's probably not, it's just that the --filecheck arg is missing. I wrote things this way because I was advised that dotest.py shouldn't assume where FileCheck is on the filesystem.

vedant

> On Oct 11, 2018, at 3:22 PM, Zachary Turner <zturner at google.com> wrote:
> 
> Why is FileCheck missing in the first place?
> On Thu, Oct 11, 2018 at 3:13 PM Vedant Kumar via Phabricator <reviews at reviews.llvm.org <mailto:reviews at reviews.llvm.org>> wrote:
> vsk created this revision.
> vsk added reviewers: stella.stamenova, zturner.
> 
> This allows bots which haven't updated to pass in --filecheck to dotest.py to run more tests. FileCheck-dependent tests will continue to fail.
> 
> 
> https://reviews.llvm.org/D53175 <https://reviews.llvm.org/D53175>
> 
> Files:
>   lldb/packages/Python/lldbsuite/test/dotest.py
> 
> 
> Index: lldb/packages/Python/lldbsuite/test/dotest.py
> ===================================================================
> --- lldb/packages/Python/lldbsuite/test/dotest.py
> +++ lldb/packages/Python/lldbsuite/test/dotest.py
> @@ -311,8 +311,8 @@
>          # The CMake build passes in a path to a working FileCheck binary.
>          configuration.filecheck = os.path.abspath(args.filecheck)
>      else:
> -        logging.error('No valid FileCheck executable; aborting...')
> -        sys.exit(-1)
> +        logging.warning('No valid FileCheck executable; some tests may fail...')
> +        logging.warning('(Pass in a --filecheck argument to dotest.py)')
> 
>      if args.channels:
>          lldbtest_config.channels = args.channels
> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20181011/fe30548c/attachment.html>