<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">It's probably not, it's just that the --filecheck arg is missing. I wrote things this way because I was advised that dotest.py shouldn't assume where FileCheck is on the filesystem.<div class=""><br class=""></div><div class="">vedant<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Oct 11, 2018, at 3:22 PM, Zachary Turner <<a href="mailto:zturner@google.com" class="">zturner@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class="">Why is FileCheck missing in the first place?<br class=""><div class="gmail_quote"><div dir="ltr" class="">On Thu, Oct 11, 2018 at 3:13 PM Vedant Kumar via Phabricator <<a href="mailto:reviews@reviews.llvm.org" class="">reviews@reviews.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">vsk created this revision.<br class="">
vsk added reviewers: stella.stamenova, zturner.<br class="">
<br class="">
This allows bots which haven't updated to pass in --filecheck to dotest.py to run more tests. FileCheck-dependent tests will continue to fail.<br class="">
<br class="">
<br class="">
<a href="https://reviews.llvm.org/D53175" rel="noreferrer" target="_blank" class="">https://reviews.llvm.org/D53175</a><br class="">
<br class="">
Files:<br class="">
lldb/packages/Python/lldbsuite/test/dotest.py<br class="">
<br class="">
<br class="">
Index: lldb/packages/Python/lldbsuite/test/dotest.py<br class="">
===================================================================<br class="">
--- lldb/packages/Python/lldbsuite/test/dotest.py<br class="">
+++ lldb/packages/Python/lldbsuite/test/dotest.py<br class="">
@@ -311,8 +311,8 @@<br class="">
# The CMake build passes in a path to a working FileCheck binary.<br class="">
configuration.filecheck = os.path.abspath(args.filecheck)<br class="">
else:<br class="">
- logging.error('No valid FileCheck executable; aborting...')<br class="">
- sys.exit(-1)<br class="">
+ logging.warning('No valid FileCheck executable; some tests may fail...')<br class="">
+ logging.warning('(Pass in a --filecheck argument to dotest.py)')<br class="">
<br class="">
if args.channels:<br class="">
lldbtest_config.channels = args.channels<br class="">
<br class="">
<br class="">
</blockquote></div>
</div></blockquote></div><br class=""></div></body></html>