[Lldb-commits] [PATCH] D51578: DWARFConcatenatingDataExtractor for D32167

Jan Kratochvil via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Sep 13 08:56:05 PDT 2018

jankratochvil added a comment.

In https://reviews.llvm.org/D51578#1233518, @clayborg wrote:

> Is there a reason we need DWARFConcatenatingDataExtractor? Can we just put all functionality into DWARFDataExtractor?

OK, I will try it that way.

> Also is there a reason we need to pass the block data in code such as:
>   const DWARFDataExtractor &debug_info_data = die.GetData().GetDWARFDataExtractor(form_value.BlockData());

Otherwise I would have to refactor more functions (using that `debug_info_data`) to use `DWARFConcatenatingDataExtractor` instead of current `DWARFDataExtractor`. But given you propose to radically merge both together I agree that `GetDWARFDataExtractor` may no longer be needed.

I am sorry I will be now for 2 weeks away.



More information about the lldb-commits mailing list