[Lldb-commits] [PATCH] D51578: DWARFConcatenatingDataExtractor for D32167

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Sep 13 08:37:04 PDT 2018

clayborg added a comment.

Overall I am ok with minimal regression in speed if a few percent is all that it is costing us. I am generally ok with this patch. A few questions below.

Is there a reason we need DWARFConcatenatingDataExtractor? Can we just put all functionality into DWARFDataExtractor? Then the only place we need to modify if the place that parses the old CU and the type units from .debug_types.

Also is there a reason we need to pass the block data in code such as:

  const DWARFDataExtractor &debug_info_data = die.GetData().GetDWARFDataExtractor(form_value.BlockData());



More information about the lldb-commits mailing list