[Lldb-commits] [PATCH] D51661: Print column info in backtraces et al. if available

[Adrian Prantl via Phabricator via lldb-commits]

aprantl added inline comments.


================
Comment at: source/Core/Debugger.cpp:123
+#define FILE_AND_LINE                                                          \
+  "{ at ${line.file.basename}:${line.number}${line.column}}"
 #define IS_OPTIMIZED "{${function.is-optimized} [opt]}"
----------------
clayborg wrote:
> Add the colon between the ${line.number} and ${line.column} here, not as part of the "${line.column}" formatting itself.
> 
> ```
>   "{ at ${line.file.basename}:${line.number}:${line.column}}"
> ```
But then the colon would be printed even if there is no column. Some frames may not have column info. I'd like to have it look like this:

```
frame #0 at hello.c:100:42
frame #1 at nocolumns.cpp:50
...
```


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D51661