[Lldb-commits] [PATCH] D51661: Print column info in backtraces et al. if available

[Greg Clayton via Phabricator via lldb-commits]

clayborg added a comment.

We shouldn't have the colon character be part of the ${line.column} formatting itself. See inlined comments.



================
Comment at: source/Core/Debugger.cpp:123
+#define FILE_AND_LINE                                                          \
+  "{ at ${line.file.basename}:${line.number}${line.column}}"
 #define IS_OPTIMIZED "{${function.is-optimized} [opt]}"
----------------
Add the colon between the ${line.number} and ${line.column} here, not as part of the "${line.column}" formatting itself.

```
  "{ at ${line.file.basename}:${line.number}:${line.column}}"
```


================
Comment at: source/Core/FormatEntity.cpp:1821
+    if (sc && sc->line_entry.IsValid() && sc->line_entry.column) {
+      const char *format = ":%" PRIu32;
+      if (!entry.printf_format.empty())
----------------
Remove the colon character from format.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D51661