[Lldb-commits] [lldb] r340652 - Fixed windows bots that were failing because of PATH_MAX

Raphael Isemann via lldb-commits lldb-commits at lists.llvm.org
Fri Aug 24 13:55:23 PDT 2018

Author: teemperor
Date: Fri Aug 24 13:55:23 2018
New Revision: 340652

URL: http://llvm.org/viewvc/llvm-project?rev=340652&view=rev
Fixed windows bots that were failing because of PATH_MAX

As we only use PATH_MAX for an assert in a unit test that is supposed
to catch the random failures on the Swift CI bots, we might as well
just ifdef this assert out on Windows.


Modified: lldb/trunk/unittests/Interpreter/TestCompletion.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/unittests/Interpreter/TestCompletion.cpp?rev=340652&r1=340651&r2=340652&view=diff
--- lldb/trunk/unittests/Interpreter/TestCompletion.cpp (original)
+++ lldb/trunk/unittests/Interpreter/TestCompletion.cpp Fri Aug 24 13:55:23 2018
@@ -165,7 +165,9 @@ TEST_F(CompletionTest, DirCompletionAbso
   // for that directory, not items under it.
   // Sanity check that the path we complete on exists and isn't too long.
+#ifdef PATH_MAX
   ASSERT_LE(BaseDir.size(), static_cast<size_t>(PATH_MAX));
   size_t Count =
       CommandCompletions::DiskDirectories(BaseDir, Results, Resolver);
   ASSERT_EQ(1u, Count);

More information about the lldb-commits mailing list