[Lldb-commits] [PATCH] D50912: Don't cancel the current IOHandler when we push a handler for an utility function run.

[Greg Clayton via Phabricator via lldb-commits]

clayborg added inline comments.


================
Comment at: include/lldb/Target/Process.h:479
+    else
+      m_running_utility_function--;
+  }
----------------
Might want this to be:

```
else if (m_running_utility_function > 0)
  --m_running_utility_function;
```

Just to make sure we don't ever underflow


================
Comment at: source/Target/Process.cpp:4696-4697
+    // the IOHandler for Editline).
+    bool cancel_top_handler = m_mod_id.IsRunningUtilityFunction();
+    GetTarget().GetDebugger().PushIOHandler(io_handler_sp, cancel_top_handler);
     return true;
----------------
Do we still need this extra bool to PushIOHandler? Can't we do the code snippet I suggested above?


https://reviews.llvm.org/D50912